Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Cross compile to x86 from arm64 on mac #1813

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

tobil4sk
Copy link
Member

@tobil4sk tobil4sk commented Jul 8, 2024

I'm not sure if -64 is the right flag to use here (since arm64 is a 64 bit architecture too), maybe it would be better to use something more specific like -x86-64?

@joshtynjala
Copy link
Member

I'm not sure if -64 is the right flag to use here (since arm64 is a 64 bit architecture too), maybe it would be better to use something more specific like -x86-64?

We're already using -64 and -32 in a lot of places to mean 32-bit and 64-bit x86. With that in mind, I think that we should continue to use -64 here for consistency.

However, I am not against adding an alternate flag that means the same thing, but has a clearer name. Perhaps even making that alternate the new default and deprecating -32 and -64 to eventually get removed in a few years or whatever.

@tobil4sk
Copy link
Member Author

tobil4sk commented Jul 9, 2024

With that in mind, I think that we should continue to use -64 here for consistency.

Makes sense, thanks.

However, I am not against adding an alternate flag that means the same thing, but has a clearer name.

Sounds good. Maybe we should deal with adding these in a separate PR/issue, because it looks like android ios is already using "i386" so we'll have to decide on consistent names for these.

@tobil4sk
Copy link
Member Author

Merging, and we can decide on the new flags in #1819.

@tobil4sk tobil4sk merged commit 4fa31a0 into openfl:8.2.0-Dev Jul 14, 2024
26 checks passed
@tobil4sk tobil4sk deleted the feature/cross-compile-mac branch July 14, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants